Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 0a9e548b2f8c
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: acd2d19484e5
Choose a head ref
  • 14 commits
  • 65 files changed
  • 2 contributors

Commits on Nov 1, 2019

  1. common setup hooks: set -u robustness

    Explicitly handle `dont*` and friends not being defined.
    Ericson2314 committed Nov 1, 2019
    Copy the full SHA
    43a9886 View commit details
    Browse the repository at this point in the history
  2. bintools-wrapper: Don't stop set -u-ing

    Same justification as previous commit.
    Ericson2314 committed Nov 1, 2019
    Copy the full SHA
    545e751 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d21a660 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    3835442 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    1290e53 View commit details
    Browse the repository at this point in the history
  6. treewide: Make still dont* Variables are optional in most cases

    Go beyond the obvious setup hooks now, with a bit of sed, with a skipped case:
    
     - cc-wrapper's `dontlink`, because it already is handled.
    
    Also, in nix files escaping was manually added.
    
    EMP
    Ericson2314 committed Nov 1, 2019
    Copy the full SHA
    2811b03 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    7eecf4f View commit details
    Browse the repository at this point in the history
  8. treewide: *Phase(s)? variables are optional

    If these aren't defined, the stdenv defaults are used in the `*Phase`
    case, or no extra phases are done, in the `*Phases` case.
    Ericson2314 committed Nov 1, 2019
    Copy the full SHA
    b7f4bda View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    45e5e68 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    373236c View commit details
    Browse the repository at this point in the history
  11. stdenv: Don't stop set -u-ing

    Before, we very carefully unapplied and reapplied `set -u` so the rest
    of Nixpkgs could continue to not fail on undefined variables. Let's rip
    off the band-aid.
    Ericson2314 committed Nov 1, 2019
    Copy the full SHA
    9df7efe View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2019

  1. qtbase-setup-hook: postPhases may be undefined

    My earlier sed missed this because it already had `{..}`.
    Ericson2314 committed Nov 2, 2019
    Copy the full SHA
    9b274e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. multiple-outputs setup hook: Remove accidentally added tab

    I don't want to just rebase this away because the original commit is
    also in #72074.
    Ericson2314 committed Nov 5, 2019
    Copy the full SHA
    c5cf009 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #72347 from NixOS/bash-no-undef-vars

    treewide: `set -u` everywhere
    Ericson2314 committed Nov 5, 2019
    Copy the full SHA
    acd2d19 View commit details
    Browse the repository at this point in the history