Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update-python-libraries: update usage comments #72733

Merged
merged 1 commit into from Nov 3, 2019
Merged

update-python-libraries: update usage comments #72733

merged 1 commit into from Nov 3, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 3, 2019 •
edited

Motivation for this change

had an issue recently of the update script selecting frozen versions and bumping them. Generally these frozen version already have the lastest in a given major series, so no need for updating logic for them.

Couldn't test because I'm not at home: didn't want to burn all my mobile data.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner November 3, 2019 18:04
@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

I don't want to force this in the code. By passing pkgs/development/python-modules/**/default.nix the same is achieved.

@jonringer
Copy link
Contributor Author

that's fair, I'll update the usage comment then, @FRidh

@jonringer jonringer changed the title update-python-libraries: only bump default.nix update-python-libraries: update usage comments Nov 3, 2019
@jonringer jonringer merged commit deb201b into NixOS:master Nov 3, 2019
@jonringer jonringer deleted the prevent-frozen-python-bumps branch November 3, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh