Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.3.1 -> 2.3.2 #72731

Merged
merged 2 commits into from Nov 4, 2019
Merged

nix-prefetch-github: 2.3.1 -> 2.3.2 #72731

merged 2 commits into from Nov 4, 2019

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 3, 2019 •
edited

Motivation for this change

nix-prefetch-github changed upstream.

Things done

Update the source and the version identifier of nix-prefetch-github in pythonPackages and of top level package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace suggested changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have two versions of the same expression, one from pypi and another from GitHub?

Couldn't we have one at python-modules and alias it in all-packages.nix with toPythonApplication?

@seppeljordan
Copy link
Contributor Author

@worldofpeace Thank you for your feedback. Let me know if there are more things that I should change.

@FRidh FRidh merged commit d7a618a into NixOS:master Nov 4, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace Thank you for your feedback. Let me know if there are more things that I should change.

Yep, perfect. Thanks for fixing that ✨

@seppeljordan seppeljordan deleted the update-nix-prefetch-github branch November 4, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @worldofpeace @FRidh