Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zfs: ZED config module #72734

Merged
merged 1 commit into from Dec 5, 2019
Merged

nixos/zfs: ZED config module #72734

merged 1 commit into from Dec 5, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 3, 2019 •
edited

Motivation for this change

Continue work from #64306

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre nyanloutre changed the title Zfs zed config module nixos/zfs: ZED config module Nov 3, 2019
infinisil
infinisil requested changes Nov 23, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking pretty good!

nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Show resolved Hide resolved
@nyanloutre
Copy link
Member Author

@infinisil Is it good ? I can squash the commits if it's ready to be merged

infinisil
infinisil approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! After your squash I'll merge

@nyanloutre
nixos/zfs: Adding ZED configuration options
c082e13 
Co-authored-by: sjau <github.com@sjau.ch>
@nyanloutre
Copy link
Member Author

@infinisil I squashed all into one commit

@infinisil infinisil merged commit 89b1bd1 into NixOS:master Dec 5, 2019
@nyanloutre nyanloutre deleted the zfs_zed_config_module branch December 5, 2019 09:01
@Mic92 Mic92 mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @infinisil