Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-studio: Fixed Flutter "TLS Error" on flutter pub get #72777

Merged
merged 1 commit into from Nov 6, 2019
Merged

android-studio: Fixed Flutter "TLS Error" on flutter pub get #72777

merged 1 commit into from Nov 6, 2019

Conversation

cab404
Copy link
Member

@cab404 cab404 commented Nov 4, 2019

This fixes Flutter SDK failing on flutter pub, due to missing certificates.
Flutter does not check /etc/ssl, and can only find them in /etc/pki.

Motivation for this change

Flutter is a popular framework, and it would be great for it to work on NixOS.

Things done

Symlinked /etc/ssl/certs to /etc/pki/tls/certs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos

@cab404
[fix] android-studio: added certificate bundle to /etc/pki
d860623 
This fixes Flutter SDK failing on flutter pub, due to missing certificates.
Flutter does not check /etc/ssl, and can only find them in /etc/pki.
@cab404 cab404 changed the title [fix] android-studio: added certificate bundle to /etc/pki [fix] android-studio: fixed Flutter "TLS Error" on flutter pub get Nov 4, 2019
@cab404 cab404 changed the title [fix] android-studio: fixed Flutter "TLS Error" on flutter pub get [fix] android-studio: Fixed Flutter "TLS Error" on flutter pub get Nov 4, 2019
@cab404 cab404 changed the title [fix] android-studio: Fixed Flutter "TLS Error" on flutter pub get android-studio: Fixed Flutter "TLS Error" on flutter pub get Nov 4, 2019
@ofborg ofborg bot requested a review from primeos November 4, 2019 14:22
@matthewbauer matthewbauer merged commit eeba5c8 into NixOS:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cab404 @matthewbauer @Janik-Haag