openarena: Update link from oa_ded to openarena-server #72824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preserves the previous behavior. Alternatively we can keep the binary name used in the distribution and update the nixos config and test. |
|
I'm happy with either name. What do you think the systemd unit name should be?
Binary = oa_ded
Unit name = openarena-server
?
…On Tue, 5 Nov 2019, at 8:59 PM, Kevin Cox wrote:
@tomfitzhenry <https://github.com/tomfitzhenry>
This preserves the previous behavior. Alternatively we can keep the binary name used in the distribution and update the nixos config and test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#72824?email_source=notifications&email_token=AAAO6536MYREJ3GJEWX3TGLQSE7X5A5CNFSM4JJAKAMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDCIUDI#issuecomment-549751309>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAO65ZI6MK5FUKTFORQITTQSE7X5ANCNFSM4JJAKAMA>.
|
|
Yeah, that is what I would do just to keep the binary name consistent. Do you want to send a patch for that then? |
10 tasks
Lassulus
pushed a commit
that referenced
this pull request
Nov 24, 2019
The binary name was recently changed from openarena-server to oa_ded in #71122 . That change broke the openarena module and consequently the openarena test too. This commit fixes both. As an alternative, we considered reverting the name change in #72824 but we decided oa_ded was a better name for the binary (it's the name upstream use).
|
My understanding, this is not needed after #73553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
230fc22 was lost in #71122
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @