Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: switch to using opencv4 #72749

Merged
merged 1 commit into from Nov 24, 2019
Merged

nomacs: switch to using opencv4 #72749

merged 1 commit into from Nov 24, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 4, 2019 •
edited

Motivation for this change

opencv 2.x has known, unfixed security vulnerabilities and is reaching EOL. nomacs itself states the minimum supported version is 3.4 & includes a script to install opencv 4.x, suggesting it is supported.

Darwin requires an extra patch to update its cmake file to make it less restrictive over this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ahmedtd

@risicle
nomacs: switch to using opencv4
a035d8d 
opencv2 has known, unfixed security vulnerabilities. nomacs itself
states the minimum supported version is 3.4 & includes a script to
install opencv4, suggesting it is supported

darwin requires a patch to update its cmake file to make it less
restrictive over this
@risicle
Copy link
Contributor Author

risicle commented Nov 9, 2019

@GrahamcOfBorg build nomacs

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2019

To check Darwin:
@GrahamcOfBorg build nomacs

@c0bw3b c0bw3b merged commit 817b066 into NixOS:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @c0bw3b