Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests to Python #72833

Merged
merged 7 commits into from Nov 6, 2019
Merged

Port tests to Python #72833

merged 7 commits into from Nov 6, 2019

Conversation

marijanp
Copy link
Contributor

@marijanp marijanp commented Nov 5, 2019

Motivation for this change

Processing the task list in issue #72828.

Now that PR #71684 (nixos: add python testing support) by @tfc got merged, I would like to port some of the tests to Python.

Things done

Ported several tests to Python, which also conform the Black code style.
Tests have been run and all of them succeed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @flokli

@marijanp
Copy link
Contributor Author

marijanp commented Nov 5, 2019

This PR can be marked as a WIP as I will continue port more of the tasks listed in #72828 the next few days. @flokli @tfc

@worldofpeace
Copy link
Contributor

Babeld got merged in a smaller PR #72834.
Perhaps it would be better to merge this now and in smaller pieces.

@marijanp
Copy link
Contributor Author

marijanp commented Nov 6, 2019

@worldofpeace I've removed my changes for babeld

@domenkozar domenkozar merged commit f103882 into NixOS:master Nov 6, 2019
@worldofpeace
Copy link
Contributor

Thanks @marijanp

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
Port tests to Python

(cherry picked from commit f103882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants