Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twa: 1.8.0 -> 1.9.1 #72742

Merged
merged 1 commit into from Nov 11, 2019
Merged

twa: 1.8.0 -> 1.9.1 #72742

merged 1 commit into from Nov 11, 2019

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Nov 3, 2019

Motivation for this change

To close #72689 by providing a working alternative

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Avaq
Copy link
Member Author

Avaq commented Nov 3, 2019

I have found two minor issues in this version of twa: trailofbits/twa#66 and trailofbits/twa#67. I'm expecting the author to fix these soon. If this PR has not been merged by that time, I will update the package version and PR title.

@woodruffw
Copy link

Upstream here: Thanks. I've cut 1.9.1 with both fixes.

@Avaq Avaq changed the title twa: 1.8.0 -> 1.9.0 twa: 1.8.0 -> 1.9.1 Nov 3, 2019
@Avaq
Copy link
Member Author

Avaq commented Nov 3, 2019

Updated to 1.9.1 and retested. Upstream fixes confirmed.

c0bw3b
c0bw3b reviewed Nov 9, 2019
View reviewed changes
pkgs/tools/networking/twa/default.nix Outdated
gawk
host.dnsutils
jq
makeWrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeWrapper belongs in nativeBuildInputs as it's used during build but not necessary at runtime.

@Avaq
twa: 1.8.0 -> 1.9.1
776d4c1 
This commit updates twa from version 1.8.0 to version 1.9.1,
specifying its new 'jq' dependency.

It also moves 'makeWrapper' from the build inputs to the native
build inputs, as it's not necessary during runtime.
@Avaq
Copy link
Member Author

Avaq commented Nov 11, 2019

@c0bw3b I moved makeWrapper to the nativeBuildInputs, also describing the change in the commit message.

c0bw3b
c0bw3b approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit c64e9da into NixOS:master Nov 11, 2019
@Avaq Avaq deleted the avaq/twa-190 branch November 12, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Avaq @woodruffw @c0bw3b