Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.* 2019.2.3 -> 2019.2.4 (mostly) #72740

Merged
merged 13 commits into from Nov 13, 2019
Merged

jetbrains.* 2019.2.3 -> 2019.2.4 (mostly) #72740

merged 13 commits into from Nov 13, 2019

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Nov 3, 2019

Motivation for this change

New releases of jetbrains Idea's.

I had an issue with Goland since I upgraded to nixos 19.09, since there is an updated version already, this midght fix it.

I've tested Goland, Clion and Phpstorm, I don't use the others.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo @loskutov @miltador @schristo @abaldeau

@kolaente kolaente requested a review from edwtjo as a code owner November 3, 2019 20:11
@kolaente
Copy link
Member Author

kolaente commented Nov 3, 2019 •
edited

I've opened an issue at jetbrains about the Goland issue I was having: https://youtrack.jetbrains.com/issue/GO-8309

EDIT: Looks like this was a problem with my color scheme, nothing specific to goland.

EDIT2: The EAP-Version does not have the bug. The next final version will be released in about a month, without that bug.

@kolaente
Copy link
Member Author

kolaente commented Nov 7, 2019

Goland was updated to 2019.2.5, I updated.

@kolaente
Copy link
Member Author

kolaente commented Nov 7, 2019

Looks like we need to wait a bit
https://twitter.com/GoLandIDE/status/1192558666760826880?s=19

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019 •
edited

Wasn't 2019.2.5 the release that fixed the bug mentioned on your Twitter link?

@kolaente
Copy link
Member Author

@c0bw3b looks like it, yes

@c0bw3b c0bw3b merged commit 2cd1695 into NixOS:master Nov 13, 2019
@kolaente
Copy link
Member Author

@c0bw3b thanks! Should I backport this to 19.09?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

I'm not sure there is bugfixes "serious" enought to warrant a backport.

Users on stable release can add nixos-unstable as a secondary channel in their user env and install fresher versions of some packages from this channel.

@kolaente kolaente deleted the update/jetbrains branch November 13, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolaente @c0bw3b