Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.51.0.72 -> 8.51.0.86 [19.09] #72822

Merged
merged 1 commit into from Nov 5, 2019
Merged

skypeforlinux: 8.51.0.72 -> 8.51.0.86 [19.09] #72822

merged 1 commit into from Nov 5, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Nov 5, 2019

Motivation for this change

In current stable branch, skypeforlinux tries to download a package that does not exist anymore:

$ nix run -f channel:nixos-19.09 skype
builder for '/nix/store/kjji0nvxp0bfdayxy1mkr41k15h33ljn-skypeforlinux_8.51.0.72_amd64.deb.drv' failed with exit code 1; last 7 log lines:
  
  trying https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.51.0.72_amd64.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download skypeforlinux_8.51.0.72_amd64.deb from any mirror
cannot build derivation '/nix/store/p3p4z5h6f224547s66bzcampp3gk9gyv-skypeforlinux-8.51.0.72.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/p3p4z5h6f224547s66bzcampp3gk9gyv-skypeforlinux-8.51.0.72.drv' failed

This PR updates skype to a version available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @PanAeon @jraygauthier

@ofborg ofborg bot requested a review from jraygauthier November 5, 2019 09:19
c0bw3b
c0bw3b approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 29ed91b into NixOS:release-19.09 Nov 5, 2019
@c0bw3b c0bw3b mentioned this pull request Nov 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsix @c0bw3b