Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: v1.6.2 -> v1.6.3 #72821

Merged
merged 1 commit into from Nov 5, 2019
Merged

podman: v1.6.2 -> v1.6.3 #72821

merged 1 commit into from Nov 5, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 5, 2019 •
edited

Motivation for this change

Update podman to the latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@saschagrunert
podman: v1.6.2 -> v1.6.3
b5d4298 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@ofborg ofborg bot requested review from ehmry and vdemeester November 5, 2019 07:59
vdemeester
vdemeester approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@grahamc grahamc merged commit 8853b8c into NixOS:master Nov 5, 2019
@saschagrunert saschagrunert deleted the podman branch November 5, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @vdemeester @ehmry @grahamc