Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the update-org script couldn't be used, as it is currently
broken. The upgrade was thus done by hand.
I also intend to backport this, as org-mode appears to be conservative with patch-level upgrades, and the git log between the two versions is basically only backports. Please confirm that's ok with you.
I have checked that the
emacs
ofnix-build -E 'with import [...]/nixpkgs {}; pkgs.emacsWithPackages (epkgs: [ epkgs.orgPackages.org-plus-contrib epkgs.orgPackages.org ])'
appears to be parsing correctly and to be parsing a file OK and to be using my org config.Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @rasendubi @ttuegel