Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-packages: 9.2.3 -> 9.2.6 #72755

Merged
merged 1 commit into from Nov 5, 2019
Merged

org-packages: 9.2.3 -> 9.2.6 #72755

merged 1 commit into from Nov 5, 2019

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Nov 4, 2019

Note that the update-org script couldn't be used, as it is currently
broken. The upgrade was thus done by hand.

I also intend to backport this, as org-mode appears to be conservative with patch-level upgrades, and the git log between the two versions is basically only backports. Please confirm that's ok with you.

I have checked that the emacs of nix-build -E 'with import [...]/nixpkgs {}; pkgs.emacsWithPackages (epkgs: [ epkgs.orgPackages.org-plus-contrib epkgs.orgPackages.org ])' appears to be parsing correctly and to be parsing a file OK and to be using my org config.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rasendubi @ttuegel

Note that the update-org script couldn't be used, as it is currently
broken. The upgrade was thus done by hand.
@adisbladis
Copy link
Member

@Ekleog I had a quick look and backporting looks fine to me, feel free :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants