Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: Fix patch that doesn't apply in v0.15.0 #74680

Merged
merged 1 commit into from Nov 29, 2019
Merged

kitty: Fix patch that doesn't apply in v0.15.0 #74680

merged 1 commit into from Nov 29, 2019

Conversation

anmonteiro
Copy link
Member

Motivation for this change

The upgrade to kitty 0.15 in d1cf282 broke the package build for me because one of the patches doesn't apply anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27 who's listed as the author of the commit above.

@Ma27
Copy link
Member

Ma27 commented Nov 29, 2019

@GrahamcOfBorg build kitty

@Ma27 Ma27 merged commit 05aff9a into NixOS:master Nov 29, 2019
@Ma27
Copy link
Member

Ma27 commented Nov 29, 2019

@anmonteiro thanks!

@anmonteiro anmonteiro deleted the anmonteiro/fix-kitty-0.15-patch branch November 29, 2019 21:55
@marsam marsam mentioned this pull request Nov 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @Ma27