Don't set taskcluster variables when we don't want to run the task #20542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had a single let block setting all the variables for the .taskcluster.yml file. But this was evaluated even on events for which we don't run tasks. That caused bogus failures because the logic didn't account for all the possible event types. Instead only evaluate the variables used in the task definition in a block guarded by "if run_task".
stephenmcgruer
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a single let block setting all the variables for the
.taskcluster.yml file. But this was evaluated even on events for which
we don't run tasks. That caused bogus failures because the logic
didn't account for all the possible event types.
Instead only evaluate the variables used in the task definition in
a block guarded by "if run_task".