Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "environment.noXlibs: do not pull gobject-introspection" #74760

Merged
merged 2 commits into from Dec 1, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 1, 2019

Introspection has nothing to do with GNOME

Reverts #74715

@grahamc
Copy link
Member

grahamc commented Dec 1, 2019

Did you make this with the "revert" button? I'm surprised the commit messages doesn't have the hash of the commit being reverted.

gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python.

This reverts commit d757135
gobject-introspection has nothing to do with graphical systems or GNOME, it is needed for language bindings like Python.
@jtojnar jtojnar force-pushed the revert-74715-baloo/no-x-libs/polkit branch from de07b7f to 4cb7f43 Compare December 1, 2019 01:18
@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 1, 2019

Yup. I also noticed the merge commits are weird. Maybe something to do with Refined GitHub extension.

@jtojnar jtojnar merged commit d7cdd6b into master Dec 1, 2019
@jtojnar jtojnar deleted the revert-74715-baloo/no-x-libs/polkit branch December 1, 2019 01:34
@matthewbauer
Copy link
Member

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants