New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.testing-postgresql: init at unstable-2017-10-31 #74716
pythonPackages.testing-postgresql: init at unstable-2017-10-31 #74716
Conversation
19bc2a6
to
6a83ffd
Compare
@jonringer Shall you or someone else approve/review this? |
pkgs/development/python-modules/testing-common-database/default.nix
Outdated
Show resolved
Hide resolved
6a83ffd
to
d907f10
Compare
8f49766
to
1b77c49
Compare
@jonringer I made the review fixes and rebased so that there are no merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
[13 built, 5 copied (6.3 MiB), 1.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74716
9 package built:
python27Packages.testing-common-database python37Packages.pg8000 python37Packages.scramp python37Packages.testing-common-database python37Packages.testing-postgresql python38Packages.pg8000 python38Packages.scramp python38Packages.testing-common-database python38Packages.testing-postgresql
@GrahamcOfBorg build python27Packages.testing-common-database python37Packages.pg8000 python37Packages.scramp python37Packages.testing-common-database python37Packages.testing-postgresql python38Packages.pg8000 python38Packages.scramp python38Packages.testing-common-database python38Packages.testing-postgresql |
|
@jonringer Can I somehow test that locally on a Linux machine? Or should I just disable for darwin..? |
It builds fine on linux, you mean darwin? |
I meant: can I build for darwin on linux? If I cannot do that, then I should probably just disable darwin. |
do you mind applying my suggestions, and then I can check if ofborg is able to do the darwin build successfully |
1b77c49
to
f476475
Compare
@jonringer Done. |
@GrahamcOfBorg build python27Packages.testing-common-database python37Packages.pg8000 python37Packages.scramp python37Packages.testing-common-database python37Packages.testing-postgresql python38Packages.pg8000 python38Packages.scramp python38Packages.testing-common-database python38Packages.testing-postgresql |
actually, the darwin builder is pretty backed up, It will most likely timeout |
f476475
to
7f3e0a9
Compare
nixpkgs review passes:
|
7f3e0a9
to
bf06db5
Compare
@jonringer I've now fixed merge conflicts that had emerged since April. Is this still good to merge or should I still do something? Who could do the merging? |
Oh, apparently there's still a conflict. |
bf06db5
to
418f8eb
Compare
Alright, conflicts resolved. I now removed |
Fails to build for me:
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 5 packages built:
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages failed to build and are new build failures:
3 packages built:
|
418f8eb
to
33e4fd1
Compare
@SuperSandro2000 Thanks for the review! The failures on darwin say things like:
No idea if this is easy or even possible to fix. Should I just disable this package for darwin? I now set |
42e52c7
to
e4fb0f3
Compare
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages built:
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 6 packages built:
|
Motivation for this change
Add
testing.postgresql
Python package and its dependencies and fixes to dependencies.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @