Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment.noXlibs: do not pull gobject-introspection #74715

Merged
merged 1 commit into from Nov 30, 2019
Merged

environment.noXlibs: do not pull gobject-introspection #74715

merged 1 commit into from Nov 30, 2019

Conversation

baloo
Copy link
Member

@baloo baloo commented Nov 30, 2019

Motivation for this change

gobject-introspection should not be needed if you do not build x-libs (no gnome support). Yet systemd polls polkit which tries to pull in gnome stuff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer matthewbauer merged commit f97746b into NixOS:master Nov 30, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2019

This is not true. gobject-introspection has nothing to do with GNOME or graphical support, it is used for things like Python bindings.

@matthewbauer
Copy link
Member

Hmm... but polkit shouldn’t need gnome support right?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2019

The name is incorrect.

@jtojnar jtojnar mentioned this pull request Dec 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baloo @jtojnar @matthewbauer