Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: pip-tools: 4.2.0 -> 4.3.0 #74577

Merged
merged 1 commit into from Nov 29, 2019
Merged

python: pip-tools: 4.2.0 -> 4.3.0 #74577

merged 1 commit into from Nov 29, 2019

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 29, 2019 •
edited

Motivation for this change

There is a new pip-tools release. A commit removing the test dependency
on six is included in this release, so several tests that now pass are
being re-enabled in the check phase. The six-specific tests that still
don't pass require network access and remain disabled. Finally, drop the
dependency on first, which has been dropped by pip-tools. The full
changelog is available at https://github.com/jazzband/pip-tools/blob/f28d1a7d25c8a490071b01e48b3c1b393ada2e23/CHANGELOG.md#430-2019-11-25.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

@ofborg ofborg bot requested a review from zimbatm November 29, 2019 05:02
@zimbatm
Copy link
Member

zimbatm commented Nov 29, 2019

@jonafato: can you also remove the broken = true; meta attribute if the package builds again?

@jonafato
python: pip-tools: 4.2.0 -> 4.3.0
7f92379 
There is a new pip-tools release. A commit [removing the test dependency
on six] is included in this release, so several tests that now pass are
being re-enabled in the check phase. The six-specific tests that still
don't pass require network access and remain disabled. Finally, drop the
dependency on first, which has been dropped by pip-tools. The full
changelog is available at https://github.com/jazzband/pip-tools/blob/f28d1a7d25c8a490071b01e48b3c1b393ada2e23/CHANGELOG.md#430-2019-11-25.

[removing the test dependency on six]: jazzband/pip-tools#939
@jonafato
Copy link
Contributor Author

@zimbatm Thanks for catching that, updated.

I'll also note that some pip commands are currently broken when working with source distributions. I've opened a PR at #74651 to fix that. Until that's fixed, you'll see failures when using pip-tool to manage source distributions, but they're caused by pip rather than pip-tools itself.

jonringer
jonringer approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executables show usage

[5 built, 4 copied (1.5 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74577
3 package were built:
python27Packages.pip-tools python37Packages.pip-tools python38Packages.pip-tools

@jonringer jonringer merged commit f9ef45b into NixOS:master Nov 29, 2019
@jonafato jonafato deleted the pip-tools-4.3.0 branch November 29, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @zimbatm @jonringer