Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giflib: fix dylib names on Darwin #74620

Merged
merged 1 commit into from Dec 21, 2019
Merged

giflib: fix dylib names on Darwin #74620

merged 1 commit into from Dec 21, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 29, 2019
@ofborg ofborg bot requested a review from Fuuzetsu November 29, 2019 11:52
@Mic92
Copy link
Member

Mic92 commented Nov 29, 2019

@GrahamcOfBorg build giflib

@marsam marsam changed the base branch from master to staging December 21, 2019 02:13
@marsam marsam merged commit 27d78ad into NixOS:staging Dec 21, 2019
@marsam marsam deleted the fix-giflib-dylib branch December 21, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @Mic92