Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump1090: 2014-10-31 -> 3.7.1 #74771

Merged
merged 2 commits into from Dec 2, 2019
Merged

dump1090: 2014-10-31 -> 3.7.1 #74771

merged 2 commits into from Dec 2, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Dec 1, 2019 •
edited

Motivation for this change

The derivation uses an upstream for dump1090 that has not been updated
since 2014. FlightAware seems to have the most actively maintained
version of dump1090, so this change switches to FlightAware's
version, bringing 5 years of improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @earldouglas

@ofborg ofborg bot requested a review from earldouglas December 1, 2019 08:01
@markuskowa markuskowa self-assigned this Dec 1, 2019
@markuskowa
Copy link
Member

The flight aware dump1090 is the definitely the better version. It is worth mentioning that this version does not have an internal web server anymore, which is a breaking change. Given that the derivation has been untouched since 2014 it is probably safe to assume that this will not affect too many users. Would you mind putting a comment in the release notes?

@danieldk
Copy link
Contributor Author

danieldk commented Dec 1, 2019

The flight aware dump1090 is the definitely the better version. It is worth mentioning that this version does not have an internal web server anymore, which is a breaking change. Given that the derivation has been untouched since 2014 it is probably safe to assume that this will not affect too many users. Would you mind putting a comment in the release notes?

Good point! I'll add a commit adding a blurb to the release notes to this PR later.

earldouglas
earldouglas approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@earldouglas earldouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danieldk
dump1090: 2014-10-31 -> 3.7.1
9ab21b0 
The derivation uses an upstream for dump1090 that has not been updated
since 2014. FlightAware seems to have the most actively maintained
version of dump1090, so this change switches to FlightAware's
version, bringing 5 years of improvements.
@danieldk
rl-2003: mention the removal of dump1090's internal web server
02553c1
@danieldk
Copy link
Contributor Author

danieldk commented Dec 2, 2019

Added a commit that adds a blurb to the release notes.

@ofborg ofborg bot requested a review from earldouglas December 2, 2019 14:01
@markuskowa markuskowa merged commit 0804fd6 into NixOS:master Dec 2, 2019
@danieldk danieldk deleted the dump1090-3.7.2 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earldouglas earldouglas earldouglas approved these changes

Assignees

@markuskowa markuskowa

Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @markuskowa @earldouglas