Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.nocrypto: Fixed crashes caused by build nondeterminism #74689

Merged
merged 1 commit into from Feb 1, 2020

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 29, 2019

Motivation for this change

Fixes https://hydra.nixos.org/build/107200689

This package tries to determine cpu capabilities at compile time to use AES-NI instructions. This PR just turns off AES-NI instruction generation altogether. Should I change what I have now to make it easier to override to enable acceleration? If so, how do you think I should do that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@vbgl
Copy link
Contributor

vbgl commented Nov 30, 2019

Just to clarify the issue (I don’t have access to the build log): the problem arises if you compile “nocrypto” on a machine that has AES-NI and use the result on a machine that do not have these instructions. This patch always disable the use of AES-NI instructions to be more portable.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/112

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build ocamlPackages.nocrypto

@vbgl vbgl merged commit b08aab7 into NixOS:master Feb 1, 2020
@worldofpeace
Copy link
Contributor

Thanks @vbgl

@ahiaao ahiaao deleted the fix/nocrypto-nd branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants