Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chirp: modernize the expression by using buildPythonApplication #74518

Merged
merged 1 commit into from Dec 12, 2019

Conversation

andir
Copy link
Member

@andir andir commented Nov 28, 2019

Motivation for this change

I was asked to have a look on this since it apparently broke some time ago.

Things done

I only built the application. Testing has to be done by someone that actually own and uses HAM radio equipment (cc @hax404).

Notify maintainers

@worldofpeace
Copy link
Contributor

This ties in with the work in #74295. It doesn't seem there's a port https://chirp.danplanet.com/issues/6327. However it's not a very strong contender for removal, there's actual activity and users https://chirp.danplanet.com/projects/chirp/repository/revisions.

stdenv.mkDerivation rec {
{ stdenv
, fetchurl
, python2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work with Python 3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my best guess is there's a branch with it https://chirp.danplanet.com/projects/chirp/wiki/Linux_Python3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port isn't really complete and has a bunch of issues. Last I checked the first thing I saw was incompatible exception syntax.

@hax404
Copy link
Contributor

hax404 commented Dec 12, 2019

Tested programming of Kenwood TH-D72 and Baofeng GT-3 Radio. Works.

@andir andir merged commit b5de0c5 into NixOS:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants