Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: reference nixos tests in packages #74628

Merged
merged 3 commits into from Nov 29, 2019
Merged

treewide: reference nixos tests in packages #74628

merged 3 commits into from Nov 29, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2019 •
edited

Motivation for this change

so @r-ryantm can pick them up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92 Mic92 changed the title Nixos ref tests treewide: reference nixos tests in packages Nov 29, 2019
@Mic92 Mic92 merged commit 33e6bbd into NixOS:master Nov 29, 2019
@Mic92 Mic92 deleted the nixos-ref-tests branch July 23, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @c0bw3b