nixosTests.moinmoin: port to python #74753
Merged
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
tfc
requested changes
Dec 1, 2019
nixos/tests/moinmoin.nix
Outdated
| machine.wait_for_file("/run/moin/ExampleWiki/gunicorn.sock") | ||
|
|
||
| page = machine.succeed("curl -L http://localhost/") | ||
| assert re.search(r"If you have just installed", page) |
There was a problem hiding this comment.
if it is just a plain substring that you need to match, then REs are a big oversided. How about:
Suggested change
| assert re.search(r"If you have just installed", page) | |
| assert "If you have just installed" in machine.succeed("curl -L http://localhost/") |
nixos/tests/moinmoin.nix
Outdated
| out = machine.succeed( | ||
| "moin-ExampleWiki account create --name=admin --email=admin@example.com --password=foo 2>&1" | ||
| ) | ||
| assert re.search(r"status success", out) |
mmilata
force-pushed
the
moinmoin-python-test
branch
from
5ce3347 to
0168f41
Compare
|
@tfc good point, thanks, fixed, PTAL |
tfc
approved these changes
Dec 1, 2019
|
@GrahamcOfBorg test moinmoin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)Notify maintainers