Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irony-server: Fix build with 1.4.0 cmake files 19.09 backport #74711

Merged
merged 1 commit into from Feb 1, 2020
Merged

irony-server: Fix build with 1.4.0 cmake files 19.09 backport #74711

merged 1 commit into from Feb 1, 2020

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 30, 2019

Motivation for this change

Backports #74223 to fix https://hydra.nixos.org/build/107204242

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @deepfire

@ahiaao
irony-server: Fix build with 1.4.0 cmake files
0b28c55 
The irony-server binary package tracks the irony-server elisp package, which was
upgraded to 1.4.0. This is now failing on Hydra because upstream has refactored
the CMake build, and now require CMake files from LLVM.

(cherry picked from commit 33e0ffe)
19.09 has the same problem
@ofborg ofborg bot requested a review from deepfire November 30, 2019 00:42
deepfire
deepfire approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/112

@worldofpeace worldofpeace merged commit d3d2de8 into NixOS:release-19.09 Feb 1, 2020
@ahiaao ahiaao deleted the fix/irony-server-backport branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahiaao @nixos-discourse @deepfire @worldofpeace