Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildBazelPackage: also set the SSL_CERT_FILE environment variable #74536

Merged
merged 1 commit into from Nov 28, 2019

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

Bazel repository rules can run arbitrary code to fetch sources, which may require our SSL certificate file. Set this in the builder, instead of each individual package.

Extracted from #73097

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli

@andrew-d andrew-d mentioned this pull request Nov 28, 2019
10 tasks
@flokli flokli merged commit 8253c10 into NixOS:master Nov 28, 2019
@andrew-d andrew-d deleted the andrew/bazel-ssl-certs branch November 28, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants