Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.logs: 0.6.3 → 0.7.0 #74738

Merged
merged 1 commit into from Dec 7, 2019
Merged

ocamlPackages.logs: 0.6.3 → 0.7.0 #74738

merged 1 commit into from Dec 7, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 30, 2019

Motivation for this change

Thread-safe logging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sternenseemann

@vbgl
Copy link
Contributor Author

vbgl commented Nov 30, 2019

@GrahamcOfBorg build acgtk

sternenseemann
sternenseemann approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine and seems to work correctly as well.

@vbgl vbgl merged commit 87774e0 into NixOS:master Dec 7, 2019
@vbgl vbgl deleted the ocaml-logs-0.7.0 branch December 7, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann