Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.caffeine: unstable-2019-04-02 -> 33 #74658

Merged
merged 1 commit into from Nov 30, 2019
Merged

gnomeExtensions.caffeine: unstable-2019-04-02 -> 33 #74658

merged 1 commit into from Nov 30, 2019

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 29, 2019 •
edited

Motivation for this change

Caffeine now supports gnome-shell 3.34. Changelog available at eonpatapon/gnome-shell-extension-caffeine@a6b37de...v33.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @emanueleperuffo

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 29, 2019
@bjornfor bjornfor merged commit d62852e into NixOS:master Nov 30, 2019
@jonafato jonafato deleted the gnomeExtensions.caffeine-33 branch December 1, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@emanueleperuffo emanueleperuffo Awaiting requested review from emanueleperuffo

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonafato @bjornfor