libfprint: 1.0 -> 1.90 #74656

ghost · 2019-11-29T17:51:40Z

Motivation for this change

A huge rewrite of libfprint (fingerprint reader library) has been merged and released recently. It adds supports for USB connected fingerprint readers. (Which will add support for latest ThinkPad laptops).

I've splitted the thinkpad fork package from the main one because the dependencies and version numbers are not matching anymore. If that's an issue I can remerge them together.

DISCLAIMER : I haven't been able to test the package update yet, Lenovo has removed the firmware upgrade related to the model I'm using right now (it was causing issues, they are going to make it available again in the next days), and since this package is hardware dependant for testing, if someone with updated hardware (or previously working hardware) can test it, it would be great.

Things done

Notify maintainers

cc @abbradar

nixos-discourse · 2019-11-29T17:54:25Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/working-on-updating-libfprint-to-1-90/4958/1

pkgs/development/libraries/libfprint-thinkpad/default.nix

pkgs/development/libraries/libfprint/default.nix

worldofpeace · 2019-11-29T20:22:26Z

@GrahamcOfBorg build libfprint

pkgs/development/libraries/libfprint-thinkpad/default.nix

cizra · 2019-11-29T22:54:07Z

Hey, please feel free to remove me from maintainers. I'm not maintaining anything or even running NixOS currently (compatibility issues).

…

On Sat, Nov 30, 2019, 00:28 Elyhaka ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkgs/development/libraries/libfprint-thinkpad/default.nix <#74656 (comment)>: > + mesonFlags = [ + "-Dudev_rules_dir=${placeholder "out"}/lib/udev/rules.d" + "-Dx11-examples=false" + ]; + + postPatch = '' + substituteInPlace libfprint/meson.build \ + --replace /bin/echo ${coreutils}/bin/echo + ''; + + meta = with stdenv.lib; { + homepage = https://fprint.freedesktop.org/; + description = "A library designed to make it easy to add support for consumer fingerprint readers"; + license = licenses.lgpl21; + platforms = platforms.linux; + maintainers = with maintainers; [ abbradar ]; Okay, I keep it with Cirza as the maintainer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#74656?email_source=notifications&email_token=AAQIQFYAUMT2KHKZPH5VY4DQWGJSHA5CNFSM4JTCGL5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNOQKWI#discussion_r352251999>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQIQF7HV6KBQ5H3ZUXEYF3QWGJSHANCNFSM4JTCGL5A> .

ghost · 2019-11-30T00:22:03Z

Hello @cizra, thank you for the feedback. Do you have any idea of who should be put as a maintainer of the two packages ?

Mic92 · 2019-11-30T08:21:22Z

Is the fork still required, should we remove libfprint-thinkpad? @abbradar could still stay as a maintainer for libfprint itself.

ghost · 2019-11-30T08:59:41Z

@Mic92 : I believe the fork is not required since it is available only for some edge-case hardware. Furthermore, this fork seems to require that the fingerprint reader has been initialized with a Windows setup. The main issue is that some people may already be using it, and it will simply drop the support for them : which is not what they would expect. On other distros this would have been put in a user repositories (like ArchLinux's AUR).

I do not know what are the guidelines for a package to be added or removed to/from NixOS repositories. Is there any documentation I can refer to ?

Mic92 · 2019-11-30T09:05:34Z

We usually add removed packages to pkgs/top-level/aliases.nix to inform users.

ghost · 2019-11-30T09:17:34Z

Okay, let me know if I should remove it.

ghost · 2019-11-30T10:58:15Z

@Mic92 I see that you're mainting NUR. Do you think libfprint-thinkpad would be a better fit there ?

Mic92 · 2019-12-01T01:12:13Z

@elyhaka probably. It would be just up to someone to put it there.

Mic92 · 2019-12-01T01:12:30Z

@elyhaka I would just drop it for now.

ghost · 2019-12-01T09:43:10Z

@Mic92 : I've removed it, and added the pkgs/top-level/aliases.nix for both fprintd-thinkpad and libfprint-thinkpad.

jtojnar · 2019-12-15T05:33:22Z

This likely broke fprintd: https://hydra.nixos.org/build/108073131/nixlog/1

It is trying to find libpfrint.pc but 1.90 provides libpfrint2.pc.

c0bw3b · 2019-12-15T12:32:40Z

Upstream advertises 1.90 as a sort of beta for 2.x

ghost · 2019-12-16T11:48:47Z

Hello, I have just tested locally, and it broke fprintd : I thought I checked it correctly, but it seems I missed this. I was working directly with the library itself most of the time recently so I didn't noticed it. I would like to apologize for that, I'll be more careful next time before proposing a PR.

I have a draft PR #75435 waiting for upstream to merge the update on fprintd : maybe we should revert this change, and I add both updates inside the other draft PR ?

Upstream states that :

The current codebase is considered stable at this point. However, due to the lack of wider testing it is only released as a 1.90.0 release which can be considered a beta-release for 2.0.

I had understanding this as "It works now, but we will wait a bit before we release 2.0" (mostly for firmware upgrades from what I've read in the issues/MR on upstream).

ghost · 2019-12-17T16:55:25Z

@elyhaka

so I didn't noticed it

Using nix-review command should help you not to miss such issues: https://github.com/Mic92/nixpkgs-review
For e.g. nix-review pr 74656