Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawio: 12.2.2 -> 12.3.2 #74729

Merged
merged 1 commit into from Dec 4, 2019
Merged

drawio: 12.2.2 -> 12.3.2 #74729

merged 1 commit into from Dec 4, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Upstream changelog:

  • Updates to draw.io 12.3.2, changes from, and including, 12.2.3 to
    12.3.2 are new in this desktop release.
  • Updates to Electron 7.1.2.
  • Fixes issue where all zeros are written to file.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
drawio: 12.2.2 -> 12.3.2
9b8d88c 
Upstream changelog:

* Updates to draw.io 12.3.2, changes from, and including, 12.2.3 to
  12.3.2 are new in this desktop release.
* Updates to Electron 7.1.2.
* Fixes issue where all zeros are written to file.
@marsam marsam merged commit f469c6b into NixOS:master Dec 4, 2019
@marsam
Copy link
Contributor

marsam commented Dec 4, 2019

Thanks!

@danieldk danieldk deleted the drawio-12.3.2 branch February 16, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @marsam