Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stretchly: 0.19.1 -> 0.21.0 #74728

Merged
merged 1 commit into from Dec 2, 2019
Merged

stretchly: 0.19.1 -> 0.21.0 #74728

merged 1 commit into from Dec 2, 2019

Conversation

cdepillabout
Copy link
Member

Update stretchly to version 0.21.0.

I've changed this to use buildFHSUserEnv since I couldn't get this new version working with just patchelf. Electron apps are a pain on Nix.

I also added an automatic update script that should work with nix-shell maintainers/scripts/update.nix --argstr package stretchly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout
stretchly: 0.19.1 -> 0.21.0
8a2aefe 
Also add an automatic updater script.
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build stretchly

@cdepillabout cdepillabout mentioned this pull request Nov 30, 2019
Closed
10 tasks
@cdepillabout
Copy link
Member Author

I've been using this for a while now, and I haven't had any problems with it.

@cdepillabout cdepillabout merged commit 8b1772c into NixOS:master Dec 2, 2019
@cdepillabout cdepillabout deleted the update-stretchly branch December 2, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cdepillabout