Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.purescript-psa: init at 0.7.3 #74727

Merged
merged 2 commits into from Dec 20, 2019
Merged

nodePackages.purescript-psa: init at 0.7.3 #74727

merged 2 commits into from Dec 20, 2019

Conversation

cdepillabout
Copy link
Member

Motivation for this change

Add the purescript-psa package to nodePackages.

This was packaged live during Nix Fridays with @zimbatm.

We followed the steps in the nixpkgs manual (adding purescript-psa to pkgs/development/node-packages/node-packages-v10.json and then running generate.sh).

However, a bunch of files were modified, including pkgs/development/node-packages/node-packages-v12.nix, pkgs/development/node-packages/node-packages-v13.nix, pkgs/development/node-packages/composition-v13.nix, and pkgs/development/node-packages/node-env.nix. I committed them all (since that is what the instructions say to do), but I imagine that might not be the correct thing to do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build nodePackages.purescript-psa

cdepillabout
cdepillabout commented Nov 30, 2019
View reviewed changes
pkgs/development/node-packages/composition-v13.nix Outdated
@@ -2,7 +2,7 @@

{pkgs ? import <nixpkgs> {
inherit system;
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}:
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite worried about this change. It seems strange that generate.sh would replace pkgs.nodejs-13_x with pkgs.nodejs-8_x in this file (since it is composition-v13.nix).

I can remove this change from this PR if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like unwanted change to me as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess the real question is, is this a problem in node2nix (and should be reported upstream), or is this a problem in the generate.sh script (and a new issue opened here on the nixpkgs repo).

zimbatm
zimbatm reviewed Dec 1, 2019
View reviewed changes
pkgs/development/node-packages/node-env.nix Outdated
@@ -363,7 +363,7 @@ let

npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild

if [ "''${dontNpmInstall-}" != "1" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts treewide patch: 2811b03

node2nix should be patched to include that change to avoid generating that diff on each run.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been reported upstream in svanderburg/node2nix#162.

@adisbladis adisbladis self-assigned this Dec 2, 2019
@turboMaCk
Copy link
Member

bin/psa works as expected to me 👍 It think at least the issue with composition-v13.nix should be resolved though.

@cdepillabout cdepillabout mentioned this pull request Dec 3, 2019
Closed
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build purescript-psa pulp

@cdepillabout
Copy link
Member Author

I never ended up getting a review of this, so I fixed it up as seemed appropriate.

If this ends up causing errors in some other package, let's revert it.

@cdepillabout cdepillabout merged commit b9a83f7 into NixOS:master Dec 20, 2019
@cdepillabout cdepillabout deleted the purescript-psa-node-packages branch December 20, 2019 11:35
@zimbatm
Copy link
Member

zimbatm commented Dec 20, 2019 

 ___________ 
< Congrats! >
 ----------- 
       \     (\/)
        \   (_o |
             /  |
             \  \______
              \        )o
               /|----- |
               \|     /|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@turboMaCk turboMaCk turboMaCk left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees

@adisbladis adisbladis

Labels
6.topic: nodejs 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdepillabout @turboMaCk @zimbatm @adisbladis