-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixosTests.matomo: port to python #74756
Conversation
I did this earlier today 😢 Oh well at least I don't have to commit it so 👍 |
@GrahamcOfBorg test matomo |
https://gist.github.com/Kiwi/48e8160134ed08164923d32594dd3298 I'm wondering if it might not be better to have it more like in this gist (but I can't figure out how to keep it DRY right now so probably not like that but to have 2 VMs) because the way I did it originally I didn't realize was only creating 1VM and which is then reused between the different versions...which will cause problems. I've already been encountering them. :| I also have a setup now that I've gone through the install of that other PR I had to show that nothing anyone was worried about had happened... (which is good, since I've been using it for a while...) |
@Kiwi I think the 1VM thing is how NixOS tests work and shouldn't be a problem because persistent storage is wiped between runs? Not sure though. Only disadvantage I see is that |
One possibility would be something like this: https://gist.github.com/mmilata/a83d34417522f61c2dde33778e7a2065 (and add the beta to all-tests.nix: mmilata@1a9216a#diff-8e2944fa8b75f34d13428287028e1323) Not sure if it's better or even different wrt VM reuse. Disadvantage is that I don't know how to run the |
With the test file we have you can do
That will launch a VM with the environment the tests run (in this case the beta, but matomo.driver works as well). The VM is named
It's... a persistent state machine. :) If I test the installation process on the beta one and then do the same on the stable one it will anger matomo for trying to downgrade it. (I'm trying to add more tests than we have right now) It also means I can't test both at the same time, and have to take manual steps that I'll forget to do to make sure I'm doing everything I need to do for accurate test results. With something like the one in my gist they don't share state
|
Motivation for this change
#72828
Things done
sandbox
innix.conf
on non-NixOS linux)Notify maintainers
cc @Kiwi @florianjacob