Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new constructor to RigidMotion and use it in the interface #2384

Merged
merged 5 commits into from
Nov 30, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 30, 2019

No description provided.

astronomy/solar_system_dynamics_test.cpp Outdated Show resolved Hide resolved
ksp_plugin/interface.cpp Outdated Show resolved Hide resolved
physics/rigid_motion_body.hpp Outdated Show resolved Hide resolved
: rigid_transformation_(rigid_transformation),
angular_velocity_of_to_frame_(
rigid_transformation_.linear_map().Inverse()(
angular_velocity_of_from_frame)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a sign here? Can you add a test?

Sorry, something went wrong.

@@ -36,13 +36,12 @@ using quantities::si::Radian;
template<typename FromFrame, typename ToFrame>
class RigidMotion final {
public:
static_assert(!std::is_same_v<FromFrame, ToFrame>,
"FromFrame and ToFrame must be different");

RigidMotion(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same enable_if on this one (and probably a typename = void on the other one for disambiguation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No can do.

physics/rigid_motion_test.cpp Outdated Show resolved Hide resolved
@eggrobin eggrobin added the LGTM label Nov 30, 2019
@pleroy pleroy merged commit 0f7bedb into mockingbirdnest:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants