-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new constructor to RigidMotion and use it in the interface #2384
Conversation
: rigid_transformation_(rigid_transformation), | ||
angular_velocity_of_to_frame_( | ||
rigid_transformation_.linear_map().Inverse()( | ||
angular_velocity_of_from_frame)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be a sign here? Can you add a test?
physics/rigid_motion.hpp
Outdated
@@ -36,13 +36,12 @@ using quantities::si::Radian; | |||
template<typename FromFrame, typename ToFrame> | |||
class RigidMotion final { | |||
public: | |||
static_assert(!std::is_same_v<FromFrame, ToFrame>, | |||
"FromFrame and ToFrame must be different"); | |||
|
|||
RigidMotion( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same enable_if on this one (and probably a typename = void on the other one for disambiguation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No can do.
No description provided.