Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pick-colour-picker: init at unstable-2019-10-11 #74562

Merged
merged 1 commit into from Dec 16, 2019
Merged

pick-colour-picker: init at unstable-2019-10-11 #74562

merged 1 commit into from Dec 16, 2019

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Nov 29, 2019 •
edited

Motivation for this change

Need this for myself. Other might need it, too

Things done

Added python package "pick-colour-picker"

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mkg20001 mkg20001 changed the title package: pick-colour-picker pick-colour-picker: init at 1.5.0-3ec940 Dec 13, 2019
@mkg20001 mkg20001 marked this pull request as ready for review December 13, 2019 18:40
@mkg20001 mkg20001 mentioned this pull request Dec 14, 2019
Closed
jtojnar
jtojnar requested changes Dec 15, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pick-colour-picker/default.nix Outdated Show resolved Hide resolved
@mkg20001 mkg20001 force-pushed the feat/pick branch 2 times, most recently from fb47d4c to 3d0741c Compare December 15, 2019 17:22
@ofborg ofborg bot removed the 6.topic: python label Dec 15, 2019
@mkg20001 mkg20001 force-pushed the feat/pick branch 2 times, most recently from f4013d2 to 6a7f0da Compare December 15, 2019 17:48
@mkg20001
Copy link
Member Author

Should be ready now

@mkg20001 mkg20001 changed the title pick-colour-picker: init at 1.5.0-3ec940 pick-colour-picker: init at unstable-2019-10-11 Dec 15, 2019
jonringer
jonringer approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
double wrapped, but expected with GApps wrap + python wrap

https://github.com/NixOS/nixpkgs/pull/74562
1 package were built:
pick-colour-picker

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pick-colour-picker

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pick-colour-picker

@jonringer
Copy link
Contributor

still LGTM

@mkg20001
Copy link
Member Author

@jonringer It's ready ^^

@jonringer
Copy link
Contributor

It's been close to a day, and you addressed all of @jtojnar 's inital concerns. Merging

@jonringer jonringer merged commit 9af73d9 into NixOS:master Dec 16, 2019
@mkg20001 mkg20001 deleted the feat/pick branch June 28, 2021 04:09
@mkg20001 mkg20001 restored the feat/pick branch June 28, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkg20001 @jonringer @jtojnar