Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qnotero: 1.0.0->2.1.1 #74560

Merged
merged 3 commits into from Feb 9, 2020
Merged

qnotero: 1.0.0->2.1.1 #74560

merged 3 commits into from Feb 9, 2020

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Nov 29, 2019 •
edited

Motivation for this change

Old repo was archived,but fork by @ealbiter is still mantained

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nico202

@ofborg ofborg bot requested a review from nico202 November 29, 2019 02:19
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/86

@veprbl
Copy link
Member

veprbl commented Feb 9, 2020

@GrahamcOfBorg build qnotero

@veprbl veprbl merged commit f9735f0 into NixOS:master Feb 9, 2020
@pasqui23 pasqui23 deleted the qnotero branch February 9, 2020 10:59
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
@pasqui23 @dtzWill
qnotero: 1.0.0 -> 2.1.1 (NixOS#74560)
ea40955 
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
(cherry picked from commit f9735f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nico202 nico202 Awaiting requested review from nico202

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pasqui23 @nixos-discourse @veprbl