Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago: init at 0.12.1.0 #74557

Merged
merged 1 commit into from Nov 29, 2019
Merged

spago: init at 0.12.1.0 #74557

merged 1 commit into from Nov 29, 2019

Conversation

cdepillabout
Copy link
Member

This commit adds the spago package, a PureScript package manager and build tool.

https://github.com/spacchetti/spago

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Since spago is a Haskell package, cc @peti.

This commit adds the spago package, a PureScript package manager and build tool.

https://github.com/spacchetti/spago
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build spago

@GrahamcOfBorg build haskellPackages.spago

@@ -2594,6 +2594,7 @@ package-maintainers:
cdepillabout:
- pretty-simple
- purescript
- spago
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peti spago isn't actually on Hackage (instead I pull it from github), so is it okay to add spago to the list of packages I maintain here? Will anything bad happen if I add myself here?

Is this list strictly only for packages that are on Hackage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this list strictly only for packages that are on Hackage?

The only effect this change will have is that hackage2nix will refuse configuration files that mark this package as broken (since it has a maintainer that is going to fix the build, eventually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants