Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping mark #2381

Merged
merged 4 commits into from
Nov 29, 2019
Merged

Grouping mark #2381

merged 4 commits into from
Nov 29, 2019

Conversation

eggrobin
Copy link
Member

$"{...}".ToString(Culture.culture)

actually calls string.ToString, which has no effect; we would have to go through FormattableString, which is Framework 4.6 and therefore the distant future (the year 2015).

This results in formatting with the invariant culture in places, violating Resolution 7 of the 9th CGPM (1948) and its reaffirmation in Resolution 10 of the 22nd CGPM (2003).

Pour faciliter la lecture, les nombres peuvent être partagés en tranches de trois chiffres ; ces tranches ne sont jamais séparées par des points, ni par des virgules.
Numbers may be divided in groups of three in order to facilitate reading; neither dots nor commas are ever inserted in the spaces between groups.

We always want to format in our custom Culture.culture, and very often in an N format, so it seemed convenient to add utilities for that; added the double.FormatN extension method.

This issue was pointed out by @nepphhh on discord upon seeing this screenshot.

image

@pleroy pleroy added the LGTM label Nov 29, 2019
@eggrobin eggrobin merged commit 45e35c5 into mockingbirdnest:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants