Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the inertia tensor of the body and push it to the plugin #2379

Merged
merged 5 commits into from
Nov 28, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 24, 2019

No description provided.

serialization::Frame::PRINCIPAL_AXES, false>;

auto const moments_of_inertia =
FromXYZ<R3Element<MomentOfInertia>>(moments_of_inertia_in_tonnes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really comfortable with a non-SI-unit FromXYZ; use R3Element<double> and multiply by the appropriate unit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, in a slightly different manner.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Nov 28, 2019
@pleroy pleroy merged commit fce1277 into mockingbirdnest:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants