Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.moviepy: switch to opencv3 #74551

Merged
merged 1 commit into from Feb 5, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 29, 2019

Motivation for this change

opencv2 is essentially EOL and has security concerns

The package's setup.py itself does list its opencv dependency as opencv-python>=3.0,<4.0 so this "should be fine".

It's a tricky package to test - the tests are present in the github repo, but even then they are very much not self-contained, and none of the tests seem to cover any of the opencv-provided functionality anyway.

The package itself is a bit problematic tbh, with undeclared runtime dependencies on cli tools like ffmpeg being present.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

opencv2 is essentially EOL and has security concerns
@jonringer
Copy link
Contributor

this didn't affect the regular derivation:

Nothing changed
https://github.com/NixOS/nixpkgs/pull/74551
$ nix-shell /home/jon/.cache/nix-review/pr-74551/shell.nix

@risicle
Copy link
Contributor Author

risicle commented Nov 30, 2019

Nope, but you can try it by flipping on advancedProcessing temporarily.

@FRidh FRidh merged commit f498ceb into NixOS:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants