python38Packages.bitarray: 1.0.1 -> 1.1.0 #74544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
reviewed
Nov 30, 2019
There was a problem hiding this comment.
All tests pass, package looks good. Upstream changelog suggests no backwards incompatible changes:
https://github.com/ilanschnell/bitarray/blob/master/CHANGE_LOG#L13
bhipple
approved these changes
Nov 30, 2019
jonringer
suggested changes
Nov 30, 2019
There was a problem hiding this comment.
regression in glasgow
[nix-shell:/home/jon/.cache/nix-review/pr-74544]$ ./results/glasgow/bin/glasgow --help
Traceback (most recent call last):
File "/nix/store/126jy61w7a9fa7fc5bvanz0y49p6ws5j-python3.7-glasgow-unstable-2019-10-16/bin/.glasgow-wrapped", line 6, in <module>
from glasgow.cli import main
File "/nix/store/9jzv4x5cvpdb7l0qxkq173vnvlmvsdl3-python3.8-glasgow-unstable-2019-10-16/lib/python3.8/site-packages/glasgow/cli.py", line 22, in <module>
from .target.hardware import GlasgowHardwareTarget
File "/nix/store/9jzv4x5cvpdb7l0qxkq173vnvlmvsdl3-python3.8-glasgow-unstable-2019-10-16/lib/python3.8/site-packages/glasgow/target/hardware.py", line 7, in <module>
from nmigen.compat import *
File "/nix/store/03x279yl3m9dmym1qd52fm0nwvcb16ni-python3.8-nmigen-unstable-2019-10-17/lib/python3.8/site-packages/nmigen/compat/__init__.py", line 8, in <module>
from .sim import *
File "/nix/store/03x279yl3m9dmym1qd52fm0nwvcb16ni-python3.8-nmigen-unstable-2019-10-17/lib/python3.8/site-packages/nmigen/compat/sim/__init__.py", line 5, in <module>
from ...back.pysim import *
File "/nix/store/03x279yl3m9dmym1qd52fm0nwvcb16ni-python3.8-nmigen-unstable-2019-10-17/lib/python3.8/site-packages/nmigen/back/pysim.py", line 5, in <module>
from bitarray import bitarray
File "/nix/store/hzmva1bjldkgjiqdxjnmpdvp5m77r8pm-python3.8-bitarray-1.1.0/lib/python3.8/site-packages/bitarray/__init__.py", line 11, in <module>
from bitarray._bitarray import _bitarray, bitdiff, bits2bytes, _sysinfo
ModuleNotFoundError: No module named 'bitarray._bitarray'
although the import is from within bit array itself, so... that's not good
jonringer
approved these changes
Nov 30, 2019
There was a problem hiding this comment.
nevermind, it was just nix-shell + python interactions
https://github.com/NixOS/nixpkgs/pull/74544
9 package were built:
glasgow python27Packages.bitarray python37Packages.bitarray python37Packages.nmigen python37Packages.nmigen-boards python38Packages.bitarray python38Packages.glasgow python38Packages.nmigen python38Packages.nmigen-boards
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.8-bitarray/versions.
meta.description for python38Packages.bitarray is: '"Efficient arrays of booleans"'.
meta.homepage for python38Packages.bitarray is: '"https://github.com/ilanschnell/bitarray"
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.1.0 with grep in /nix/store/hzmva1bjldkgjiqdxjnmpdvp5m77r8pm-python3.8-bitarray-1.1.0
directory tree listing: https://gist.github.com/5779bedf90d8804331badf5e91f5b268
du listing: https://gist.github.com/f1cf3bbf2ac457c40bf7d665a975ef90
Rebuild report (if merged into master) (click to expand)
40 total rebuild path(s)
10 package rebuild(s)
10 x86_64-linux rebuild(s)
10 i686-linux rebuild(s)
10 x86_64-darwin rebuild(s)
10 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
glasgow
python27Packages.bitarray
python37Packages.bitarray
python37Packages.glasgow
python37Packages.nmigen
python37Packages.nmigen-boards
python38Packages.bitarray
python38Packages.glasgow
python38Packages.nmigen
python38Packages.nmigen-boards
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @bhipple for testing.