spotify-tui: 0.9.0 -> 0.10.0 #74739
Merged
spotify-tui: 0.9.0 -> 0.10.0 #74739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
reviewed
Nov 30, 2019
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ openssl ] | ||
| buildInputs = [ openssl python3 ] |
There was a problem hiding this comment.
please move python3 to nativeBuildInputs. Besides that, LGTM
There was a problem hiding this comment.
Oh yeah, fixed.
|
would you mind adding the following for the darwin build? diff --git c/pkgs/applications/audio/spotify-tui/default.nix i/pkgs/applications/audio/spotify-tui/default.nix
index a1ec474c217..264ab73e6a5 100644
--- c/pkgs/applications/audio/spotify-tui/default.nix
+++ i/pkgs/applications/audio/spotify-tui/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, rustPlatform, pkgconfig, openssl, python3, libxcb, Security }:
+{ stdenv, fetchFromGitHub, rustPlatform, pkgconfig, openssl, python3, libxcb, AppKit, Security }:
rustPlatform.buildRustPackage rec {
pname = "spotify-tui";
@@ -16,7 +16,7 @@ rustPlatform.buildRustPackage rec {
nativeBuildInputs = [ pkgconfig ];
buildInputs = [ openssl python3 ]
++ stdenv.lib.optional stdenv.isLinux libxcb
- ++ stdenv.lib.optional stdenv.isDarwin Security;
+ ++ stdenv.lib.optionals stdenv.isDarwin [ AppKit Security ];
meta = with stdenv.lib; {
description = "Spotify for the terminal written in Rust";
diff --git c/pkgs/top-level/all-packages.nix i/pkgs/top-level/all-packages.nix
index 3db18945819..4f124b36938 100644
--- c/pkgs/top-level/all-packages.nix
+++ i/pkgs/top-level/all-packages.nix
@@ -21109,7 +21109,7 @@ in
split2flac = callPackage ../applications/audio/split2flac { };
spotify-tui = callPackage ../applications/audio/spotify-tui {
- inherit (darwin.apple_sdk.frameworks) Security;
+ inherit (darwin.apple_sdk.frameworks) AppKit Security;
};
squishyball = callPackage ../applications/audio/squishyball { |
jwijenbergh
force-pushed
the
upgrade-spotify-tui
branch
from
10bbf88
to
dafee52
Compare
Patch applied, thanks 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to version 0.10.0. Has clipboard support so we need libxcb (on linux) and python (for building rust-xcb).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @