Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim plugins bump #74612

Merged
merged 1 commit into from Nov 29, 2019
Merged

Vim plugins bump #74612

merged 1 commit into from Nov 29, 2019

Conversation

lovesegfault
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@lovesegfault
Copy link
Member Author 

$ nix build --no-link --keep-going --max-jobs 12 --option build-use-sandbox true -f /home/bemeurer/.cache/nix-review/pr-74612/build.nix
[103 built, 21 copied (782.5 MiB), 174.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74612
54 package were built:
vimPlugins.nerdcommenter vimPlugins.YouCompleteMe vimPlugins.airline vimPlugins.alchemist-vim vimPlugins.ale vimPlugins.awesome-vim-colorschemes vimPlugins.calendar vimPlugins.coc-go vimPlugins.coc-lists vimPlugins.coc-nvim vimPlugins.coc-prettier vimPlugins.coc-python vimPlugins.coc-rls vimPlugins.coc-tsserver vimPlugins.coc-yank vimPlugins.dart-vim-plugin vimPlugins.defx-nvim vimPlugins.denite vimPlugins.deol-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.editorconfig-vim vimPlugins.ensime-vim vimPlugins.falcon vimPlugins.fugitive vimPlugins.fzf-vim vimPlugins.gentoo-syntax vimPlugins.ghcid vimPlugins.gitgutter vimPlugins.gv-vim vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.mattn-calendar-vim vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neosnippet-snippets vimPlugins.nvim-yarp vimPlugins.polyglot vimPlugins.rust-vim vimPlugins.semshi vimPlugins.sensible vimPlugins.stylishHaskell vimPlugins.surround vimPlugins.vim-airline-themes vimPlugins.vim-qml vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-wakatime vimPlugins.vimproc vimPlugins.vimshell vimPlugins.vimtex

@ofborg ofborg bot added the 6.topic: vim label Nov 29, 2019
@ofborg ofborg bot requested a review from jagajaga November 29, 2019 10:27
@jonringer
Copy link
Contributor

do you mind squashing the two commits, they both fall under the category of update

@lovesegfault
vimPlugins: update
2793c31 
vimPlugins.coc-nvim: 2019-11-18 -> 2019-11-29
@lovesegfault
Copy link
Member Author

@jonringer Done!

jonringer
jonringer approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[104 built, 21 copied (760.5 MiB), 174.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74612
54 package were built:
vimPlugins.alchemist-vim vimPlugins.ale vimPlugins.awesome-vim-colorschemes vimPlugins.calendar-vim vimPlugins.coc-go vimPlugins.coc-lists vimPlugins.coc-nvim vimPlugins.coc-prettier vimPlugins.coc-python vimPlugins.coc-rls vimPlugins.coc-tsserver vimPlugins.coc-yank vimPcopying azure/cli/command_modules/appconfig/_params.py -> build/lib/lugins.dart-vim-plugin vimPlugins.defx-nvim vimPlugins.denite-nvim vimPlugins.deol-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.editorconfig-vim vimPlugins.ensime-vim vimPlugins.falcon vimPlugins.fzf-vim vimPlugins.gentoo-syntax vimPlugins.ghcid vimPlugins.gv-vim vimPlugins.lh-brackets vimPlugins.lh-vim-lib vimPlugins.mattn-calendar-vim vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neosnippet-snippets vimPlugins.nerdcommenter vimPlugins.nvim-yarp vimPlugins.rust-vim vimPlugins.semshi vimPlugins.vim-airline vimPlugins.vim-airline-themes vimPlugins.vim-fugitive vimPlugins.vim-gitgutter vimPlugins.vim-polyglot vimPlugins.vim-qml vimPlugins.vim-sensible vimPlugins.vim-snippets vimPlugins.vim-stylish-haskell vimPlugins.vim-surround vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-wakatime vimPlugins.vimproc-vim vimPlugins.vimshell-vim vimPlugins.vimtex vimPlugins.youcompleteme

@jonringer jonringer merged commit 701ae3a into NixOS:master Nov 29, 2019
@lovesegfault lovesegfault deleted the vimPlugins-bump branch November 30, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovesegfault @jonringer