Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.openarena: port to python #74759

Merged
merged 1 commit into from Dec 2, 2019

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Dec 1, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tomfitzhenry

@ofborg ofborg bot added the 6.topic: nixos label Dec 1, 2019

# Check it's possible to join the server.
$machine->succeed("echo -n -e '\\xff\\xff\\xff\\xffgetchallenge' | socat - UDP4-DATAGRAM:127.0.0.1:27960 | grep -q challengeResponse");
# Can't use substring match instead of grep because the output is not utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I recall trying to use substring matching and it failing, and I didn't look into why. Good to know!

Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure how to trigger the test to ensure it still passes, but the code LGTM.

@mmilata
Copy link
Member Author

mmilata commented Dec 1, 2019

@tomfitzhenry Either nix-build nixos/tests/openarena.nix locally or comment @GrahamcOfBorg test openarena if you have the rights.

@flokli
Copy link
Contributor

flokli commented Dec 2, 2019

Verified test still succeed.

@flokli flokli merged commit fdb6531 into NixOS:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants