pkgs/build-support/trivial-builders: add runCommandLocal #74642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Nov 29, 2019
infinisil
requested changes
Dec 3, 2019
| // (if runLocal then { | ||
| preferLocalBuild = true; | ||
| allowSubstitutes = false; | ||
| } else {}) |
There was a problem hiding this comment.
I feel like this should be the other way around, such that env can override preferLocalBuild. Also could use optionalAttrs runLocal { ... } here
There was a problem hiding this comment.
You are absolutely right, see force push.
Tested manually with
nix-build -E 'with import ./. {}; runCommandLocal "foo" { x = "y"; preferLocalBuild = false; } "echo $x"'
Profpatsch
force-pushed
the
build-support-trivial-builders-add-runCommandLocal
branch
from
afd505b
to
affa896
Compare
A definition I’ve been copy-pasting everywhere so far, so it’s finally time to add it to nixpkgs. I’m using a remote builder for my regular nix builds, so trivial `runCommand`s which first try a substitution and then copy the inputs to the builder to run for 0.2s are quite noticable. If we just always build these, we gain some build time, so let’s make it easy to switch from remote to local.
The link in the note points to the `id` added in NixOS/nix#3255, so it might take some time to start working correctly.
This makes it possible to reference single function definitions, for pointing people to their exact definition.
Profpatsch
force-pushed
the
build-support-trivial-builders-add-runCommandLocal
branch
from
affa896
to
242b043
Compare
We shouldn’t force the user to have a C compiler in scope, just because the derivation is forced to build locally. That can’t be counted as “lightweight” anymore. Co-Authored-By: Silvan Mosberger<contact@infinisil.com>
infinisil
approved these changes
Dec 4, 2019
Profpatsch
added a commit
to openlab-aux/vuizvui
that referenced
this pull request
Dec 8, 2019
`runCommandLocal` was added to nixpkgs in NixOS/nixpkgs#74642 to speed up trivial `runCommand` derivations by always building them locally. We have a few places where that’s good to use.
Profpatsch
added a commit
to openlab-aux/vuizvui
that referenced
this pull request
Dec 8, 2019
`runCommandLocal` was added to nixpkgs in NixOS/nixpkgs#74642 to speed up trivial `runCommand` derivations by always building them locally. We have a few places where that’s good to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A definition I’ve been copy-pasting everywhere so far, so it’s finally
time to add it to nixpkgs.
I’m using a remote builder for my regular nix builds, so trivial
runCommands which first try a substitution and then copy the inputsto the builder to run for 0.2s are quite noticable.
If we just always build these, we gain some build time, so let’s make
it easy to switch from remote to local.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @infinisil