Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin: 0.18.1 -> 0.19.0.1 #74741

Merged
merged 1 commit into from Dec 3, 2019
Merged

bitcoin: 0.18.1 -> 0.19.0.1 #74741

merged 1 commit into from Dec 3, 2019

Conversation

roconnor
Copy link
Contributor

protobuf is not longer a dependency of bitcoin.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @prusnak

@roconnor
bitcoin: 0.18.1 -> 0.19.0.1
94e1737 
protobuf is not longer a dependency of bitcoin.
@roconnor roconnor mentioned this pull request Nov 30, 2019
Closed
@roconnor
Copy link
Contributor Author

I've incorporated a few of the changes from #72418 since it will need to be rebased anyway.

@ofborg ofborg bot requested a review from AndersonTorres November 30, 2019 18:38
@jb55
Copy link
Contributor

jb55 commented Nov 30, 2019

ACK 94e1737, I've verified the hash matches the one signed with the bitcoin release key.

prusnak
prusnak approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 94e1737

Lassulus
Lassulus approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit e503d20 into NixOS:master Dec 3, 2019
@Lassulus Lassulus mentioned this pull request Dec 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@Lassulus Lassulus Lassulus approved these changes

@jb55 jb55 Awaiting requested review from jb55

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor @jb55 @prusnak @Lassulus