Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mame: 0.215 -> 0.216 #74722

Merged
merged 2 commits into from Dec 17, 2019
Merged

mame: 0.215 -> 0.216 #74722

merged 2 commits into from Dec 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2019 •
edited by ghost

Motivation for this change
  • Bump version
  • Set default paths
  • Add module for network configuration

Screenshot_20191207_140453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ghost ghost changed the title mame: 0.215 -> 0.216 [WIP] mame: 0.215 -> 0.216 Dec 2, 2019
@ghost ghost requested a review from infinisil as a code owner December 6, 2019 20:45
@ghost ghost changed the title [WIP] mame: 0.215 -> 0.216 mame: 0.215 -> 0.216 Dec 6, 2019
@ghost
Copy link
Author

ghost commented Dec 7, 2019

@GrahamcOfBorg build mame

@ghost ghost requested a review from Lassulus December 15, 2019 19:38
Lassulus
Lassulus approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit f061413 into NixOS:master Dec 17, 2019
@ghost
Copy link
Author

ghost commented Dec 17, 2019

@Lassulus thank you!

@ghost ghost deleted the mame branch December 17, 2019 08:53
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 17, 2019
@Lassulus @dtzWill
Merge pull request NixOS#74722 from gnidorah/mame
0a8452f 
mame: 0.215 -> 0.216
(cherry picked from commit f061413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Lassulus