smlnj: 110.91 -> 110.95, add 64-bit support #74745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this seems to break even the latest revision of |
aske
force-pushed
the
smlnj-upd
branch
2 times, most recently
from
bad480f
to
2ccdb28
Compare
|
Fixed |
Also drop isDarwin check in `top-level/all-packages.nix` till darwin build is fixed.
|
Alright, with all changes accepted by upstream this PR is now ready. |
thoughtpolice
approved these changes
Dec 4, 2019
Comment on lines
-8726
to
-8728
| smlnj = if stdenv.isDarwin | ||
| then callPackage ../development/compilers/smlnj { } | ||
| else pkgsi686Linux.callPackage ../development/compilers/smlnj { }; |
|
@GrahamcOfBorg build smlnj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update package, use 64-bit support added in 110.94.
Also drop isDarwin check in
top-level/all-packages.nixtill darwin build is fixed.I needed to patch
heap2execfor it to run after installation; I filed an upstream bug here.With these changes on
x86_64-linuxonly 64-bit version is installed , thoughsmlnjalso supports simultaneous 32 and 64 bit installation. Would it be useful to add support for joint installation?Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @thoughtpolice