Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/abseil-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e0dd75af2c57
Choose a base ref
...
head repository: mockingbirdnest/abseil-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2b0c0442571
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Nov 30, 2019

  1. vectorcall

    eggrobin committed Nov 30, 2019
    Copy the full SHA
    b2b0c04 View commit details
6 changes: 3 additions & 3 deletions absl/debugging/failure_signal_handler.cc
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ struct FailureSignalData {
using StructSigaction = struct sigaction;
#define FSD_PREVIOUS_INIT FailureSignalData::StructSigaction()
#else
void (*previous_handler)(int);
void (__cdecl *previous_handler)(int);
#define FSD_PREVIOUS_INIT SIG_DFL
#endif
};
@@ -192,7 +192,7 @@ static void InstallOneFailureHandler(FailureSignalData* data,
#else

static void InstallOneFailureHandler(FailureSignalData* data,
void (*handler)(int)) {
void (__cdecl *handler)(int)) {
data->previous_handler = signal(data->signo, handler);
ABSL_RAW_CHECK(data->previous_handler != SIG_ERR, "signal() failed");
}
@@ -294,7 +294,7 @@ using GetTidType = decltype(absl::base_internal::GetTID());
ABSL_CONST_INIT static std::atomic<GetTidType> failed_tid(0);

#ifndef ABSL_HAVE_SIGACTION
static void AbslFailureSignalHandler(int signo) {
static void __cdecl AbslFailureSignalHandler(int signo) {
void* ucontext = nullptr;
#else
static void AbslFailureSignalHandler(int signo, siginfo_t*, void* ucontext) {
2 changes: 1 addition & 1 deletion absl/hash/internal/print_hash_of.cc
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
#include "absl/hash/hash.h"

// Prints the hash of argv[1].
int main(int argc, char** argv) {
int __cdecl main(int argc, char** argv) {
if (argc < 2) return 1;
printf("%zu\n", absl::Hash<int>{}(std::atoi(argv[1]))); // NOLINT
}
2 changes: 1 addition & 1 deletion absl/strings/ascii_benchmark.cc
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@ void AsciiBenchmark(benchmark::State& state, Function f) {
state.SetBytesProcessed(state.iterations() * bytes.size());
}

using StdAsciiFunction = int (*)(int);
using StdAsciiFunction = int (__cdecl*)(int);
template <StdAsciiFunction f>
void BM_Ascii(benchmark::State& state) {
AsciiBenchmark(state, f);
2 changes: 1 addition & 1 deletion absl/time/internal/cctz/src/time_zone_info.cc
Original file line number Diff line number Diff line change
@@ -624,7 +624,7 @@ class FileZoneInfoSource : public ZoneInfoSource {
: fp_(fp, fclose), len_(len) {}

private:
std::unique_ptr<FILE, int(*)(FILE*)> fp_;
std::unique_ptr<FILE, int(__cdecl*)(FILE*)> fp_;
std::size_t len_;
};

2 changes: 1 addition & 1 deletion absl/time/internal/cctz/src/zone_info_source.cc
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ ZoneInfoSourceFactory default_factory = DefaultFactory;
#elif defined(_M_IA_64) || defined(_M_AMD64)
#pragma comment( \
linker, \
"/alternatename:?zone_info_source_factory@cctz_extension@time_internal@absl@@3P6A?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@AEBV?$function@$$A6A?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@@Z@5@@ZEA=?default_factory@cctz_extension@time_internal@absl@@3P6A?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@AEBV?$function@$$A6A?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@@Z@5@@ZEA")
"/alternatename:?zone_info_source_factory@cctz_extension@time_internal@absl@@3P6Q?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@AEBV?$function@$$A6Q?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@@Z@5@@ZEA=?default_factory@cctz_extension@time_internal@absl@@3P6Q?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@AEBV?$function@$$A6Q?AV?$unique_ptr@VZoneInfoSource@cctz@time_internal@absl@@U?$default_delete@VZoneInfoSource@cctz@time_internal@absl@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@@Z@5@@ZEA")
#else
#error Unsupported MSVC platform
#endif
1 change: 1 addition & 0 deletions msvc/abseil-cpp.props
Original file line number Diff line number Diff line change
@@ -60,6 +60,7 @@
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
<CallingConvention>vectorcall</CallingConvention>
<LanguageStandard>stdcpp17</LanguageStandard>
<WarningLevel>Level3</WarningLevel>
<TreatWarningAsError>true</TreatWarningAsError>